-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate and display hash count of PoW #73
Conversation
Why don't just integrate |
Just want to make sure the way of getting hash times is agreed by everyone. |
I disagree with the way to place several |
I'll remove the Back to the original implementation, I was going to create a new API to get the |
It sounds fine to me.
A Qt developer wrote the article The Little Manual of API Design 10 years ago, and it is still insightful. Quoted from 4.11 Strive for property-based APIs:
It is identically important to statistics in dcurl internals. To get statistics of hash rate, developers should be able to look up certain property via dedicated APIs. In this case, it would be great if there is something like bookkeeping as |
Calculate the hash count mentioned in DLTcollab#47 in `doThePoW` function and get it with `getHashCount` API.
5b71fe3
to
22dc766
Compare
I use force push to overwrite the old commits with the new ones. Now the It would show the hash count value when building and executing |
Would it be meaingful if bench is replaced with stat, which stands for statistics and state? |
I'm ok with both naming. @chenwei-tw what do you think? |
Fine for me 👍 |
22dc766
to
2d030c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the API getPoWInfo
@marktwtn, File |
There is no |
edd5fc8
to
42b7ffc
Compare
The `getPoWInfo` API would return the PoW-related information such as hash count and PoW execution time, instead of returning the hash count value only.
42b7ffc
to
5a9aeee
Compare
3871572
to
bcd1b10
Compare
bcd1b10
to
2bf35c1
Compare
Update the `BUILD_STAT` option and testing files with the corresponding result.
2bf35c1
to
262b893
Compare
Oops, hash count in fpga implementation has not been implemented yet. |
I will send a pull request for hash count with the fpga accelerator. |
There are compile errors for the fpga-accelerated PoW (!) and I will fix it. |
By the way, we shall set up CI for building all configurations including FPGA part. |
There are also run-time errors the fpga-accelerated PoW. |
That's my bad. I did not notice it.
You can contact me on slack if you have any problem. |
@marktwtn Thanks. |
Calculate and sum the total
hash count
mentioned in #47 indoThePoW
function.The FPGA part will be implemented by @ajblane .
The
BUILD_BENCH
option and PoW execution time for hash rate will be added in the future pull requests.2018/09/23: The
BUILD_BENCH
option has been added inMakefile
.